Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow STL files bigger than expected (printing a warning message). #951

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Allow STL files bigger than expected (printing a warning message). #951

merged 1 commit into from
Dec 22, 2015

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Dec 10, 2015

See issue #945.

@caguero caguero mentioned this pull request Dec 10, 2015
Closed
@wjwwood
Copy link
Member

wjwwood commented Dec 10, 2015

Thanks @caguero!

@seanyun can you try this to see if it at least loads your STL's? Strictly speaking I think your STL's are not compliant to the STL standard (if I read it correctly).

@seanyun
Copy link

seanyun commented Dec 22, 2015

I'm sorry about the late response. This patch works. I got a bunch of warnings but the graphical model shows up in the right way. Thx!

@wjwwood
Copy link
Member

wjwwood commented Dec 22, 2015

Ok, I'll merge this, but I'd still like to know why your models have extra data at the end. Do they open in other tools like Blender and Meshlab?

wjwwood added a commit that referenced this pull request Dec 22, 2015
@wjwwood
Merge pull request #951 from ros-visualization/issue_945
c7cdc3d 
Allow STL files bigger than expected (printing a warning message).
@wjwwood wjwwood merged commit c7cdc3d into indigo-devel Dec 22, 2015
@wjwwood wjwwood deleted the issue_945 branch December 22, 2015 20:59
@seanyun
Copy link

seanyun commented Dec 22, 2015

I can open the STL files in Blender smoothly. I don't see any warning or errors in Blender.
The STL files were generated by the SolidWorks auto-export.

@JamesNewton
Copy link

JamesNewton commented Aug 16, 2020 •
edited
Loading

I seem to be having the opposite issue with the attached file. Version 1.12.14.
LowRes_DexterHDIKinematic_Link1_Bottom.stl.zip

[ERROR] [1597547617.189402847]: The STL file 'LowRes_DexterHDIKinematic_Link1_Bottom.stl' is malformed. According to the binary STL header it should have '1381248871' triangles, but it has too little data for that to be the case.

Should I open a different issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caguero @wjwwood @seanyun @JamesNewton